netdev - Re: [PATCH net-next V1 1/8] net/mlx4: Address build warnings on set but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120515.133808.1788429614608005541.davem@davemloft.net>
Date:	Tue, 15 May 2012 13:38:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	roland@...nel.org, netdev@...r.kernel.org, yevgenyp@...lanox.com
Subject: Re: [PATCH net-next V1 1/8] net/mlx4: Address build warnings on
 set but not used variables

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Tue, 15 May 2012 10:24:43 +0300

> -		err = mlx4_cmd_imm(dev, mac, &out_param, RES_MAC,
> -				   RES_OP_RESERVE_AND_MAP, MLX4_CMD_FREE_RES,
> -				   MLX4_CMD_TIME_CLASS_A, MLX4_CMD_WRAPPED);
> +		(void) mlx4_cmd_imm(dev, mac, &out_param, RES_MAC,
> +					RES_OP_RESERVE_AND_MAP, MLX4_CMD_FREE_RES,
> +					MLX4_CMD_TIME_CLASS_A, MLX4_CMD_WRAPPED);

Please stop wasting my time.  This is not the correct way to indent
functions that have arguments on multiple lines.

I'll say it one more time:

	The first character must line up with the column right after
	the openning parenthesis on the first line.

This means you DO NOT use only TAB characters and indent the thing
into the solar system like you have above.

Instead you use TAB and SPACE characters, as needed, to line it up
properly, like so:

	func(arg1, arg2,
	     arg3, arg4);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html