netdev - Re: [PATCH] pch_gbe: fix transmit races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120515.134300.588180020194758538.davem@davemloft.net>
Date:	Tue, 15 May 2012 13:43:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	andy.cress@...kontron.com, netdev@...r.kernel.org
Subject: Re: [PATCH] pch_gbe: fix transmit races

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 14 May 2012 21:26:06 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Andy reported pch_gbe triggered "NETDEV WATCHDOG" errors.
> 
> May 11 11:06:09 kontron kernel: WARNING: at net/sched/sch_generic.c:261
> dev_watchdog+0x1ec/0x200() (Not tainted)
> May 11 11:06:09 kontron kernel: Hardware name: N/A
> May 11 11:06:09 kontron kernel: NETDEV WATCHDOG: eth0 (pch_gbe):
> transmit queue 0 timed out
> 
> It seems pch_gbe has a racy tx path (races with TX completion path)
> 
> Remove tx_queue_lock lock since it has no purpose, we must use tx_lock
> instead.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andy Cress <andy.cress@...kontron.com>
> Tested-by: Andy Cress <andy.cress@...kontron.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html