[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120516.153913.686915759183202821.davem@davemloft.net>
Date: Wed, 16 May 2012 15:39:13 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: kadlec@...ckhole.kfki.hu
Cc: pablo@...filter.org, netfilter-devel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 0/4] netfilter fixes for 3.4-rc7
From: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
Date: Wed, 16 May 2012 21:34:55 +0200 (CEST)
> On Wed, 16 May 2012, David Miller wrote:
>
>> > Could at least the patch with the subject
>> >
>> > netfilter: ipset: fix hash size checking in kernel
>> >
>> > The hash size must fit both into u32 (jhash) and the max value of
>> > size_t. The missing checking could lead to kernel crash, bug reported
>> > by Seblu.
>> >
>> > be submitted into 3.4-rc7? Any non most-recent ipset package compiled with
>> > gcc-4.7 or above can trigger the bug.
>>
>> And only root can trigger it if he gives bogus parameters right?
>
> Yes, root can trigger it only, however it's a two sided bug: ipset < 6.12
> compiled with gcc >= 4.7 is broken and sends bogus data to the kernel,
> even when normal input parameters are supplied. And unpatched kernel can
> crash when acting on the bogus data. :-(
Ok, that's a more convincing argument.
I've applied the hash size validation patch to 'net'.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists