netdev - Re: [PATCH] ptp_pch: Add missing #include <linux/slab.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUa5JbopxqvoZ6rRivM4Go+cY7ZpijtB+FACuo+-TiZwA@mail.gmail.com>
Date:	Wed, 16 May 2012 13:52:25 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Takahiro Shimizu <tshimizu818@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Richard Cochran <richardcochran@...il.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ptp_pch: Add missing #include <linux/slab.h>

On Wed, May 16, 2012 at 1:40 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> On Wed, 2012-05-16 at 10:43 +0200, Geert Uytterhoeven wrote:
>> drivers/ptp/ptp_pch.c: In function 'pch_eth_enable_set':
>> drivers/ptp/ptp_pch.c:152:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
>> drivers/ptp/ptp_pch.c:153:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
>
> <linux/io.h> might be more useful.

Bummer, I copied the wrong error from the log ;-(
I resent the correct version.

But indeed, <linux/io.h> is also missing. But that error was not a regression
in 3.4-rc7 ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html