[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120517.190346.175685939436302276.davem@davemloft.net>
Date: Thu, 17 May 2012 19:03:46 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: jaccon.bastiaansen@...il.com
Cc: arnd@...db.de, joe@...ches.com, romieu@...zoreil.com,
s.hauer@...gutronix.de, gfm@...xed.com, festevam@...il.com,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH V3] CS89x0 : Use ioread16/iowrite16 on all platforms
From: Jaccon Bastiaansen <jaccon.bastiaansen@...il.com>
Date: Thu, 17 May 2012 19:11:42 +0200
> The use of the inw/outw functions by the cs89x0 platform driver
> results in NULL pointer references on ARM platforms and
> platforms that do not provide ISA-style programmed I/O accessors.
>
> Using inw/outw also accesses the wrong address space on platforms
> that have a PCI I/O space that is not identity-mapped into the
> physical address space.
>
> Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@...il.com>
I could nit-pick more on this patch, but it's such a significant
improvement I'm just going to apply this V3 as-is to net-next.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists