netdev - Re: [patch] isdn: remove duplicate NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120517.044837.2251136486222452174.davem@davemloft.net>
Date:	Thu, 17 May 2012 04:48:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	isdn@...ux-pingi.de, dhowells@...hat.com,
	ext-phil.2.carmody@...ia.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] isdn: remove duplicate NULL check

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 17 May 2012 09:51:02 +0300

> We test both "!skb_out" and "skb_out" here which is duplicative and
> causes a static checker warning.  I considered that the intent might
> have been to test "skb_in" but that's a valid pointer here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html