netdev - Re: [PATCH] bonding: only send arp monitor packets if no other traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120517.200842.2215723188229945074.davem@davemloft.net>
Date:	Thu, 17 May 2012 20:08:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	chris.friesen@...band.com
Cc:	fubar@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: only send arp monitor packets if no other
 traffic

From: Chris Friesen <chris.friesen@...band.com>
Date: Wed, 16 May 2012 12:48:28 -0600

> +		if (IS_UP(slave->dev)) {
> +			if (time_after_eq(jiffies, dev_trans_start(slave->dev) + delta_in_ticks) ||
> +			    time_after_eq(jiffies, slave->dev->last_rx + delta_in_ticks)) {
> +				bond_arp_send_all(bond, slave);
> +			}

These lines are very long, and instead of just reformatting them I'd suggest
that you simply make the test a static helper function.

Also, you should not use braces to enclose a single line of code.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html