lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120519.005137.1933841560668190190.davem@davemloft.net> Date: Sat, 19 May 2012 00:51:37 -0400 (EDT) From: David Miller <davem@...emloft.net> To: dan.carpenter@...cle.com Cc: netdev@...r.kernel.org Subject: Re: inconsistent null checking in ipx_ioctl() From: Dan Carpenter <dan.carpenter@...cle.com> Date: Mon, 14 May 2012 23:56:18 +0300 > Hi, I'm working on some new Smatch stuff and going through some warnings > in old code. > > ---- > This is a semi-automatic email about new static checker warnings. > > The patch b0d0d915d1d1: "ipx: remove the BKL" from Jan 25, 2011, > leads to the following Smatch complaint: > > net/ipx/af_ipx.c:1928 ipx_ioctl() > error: we previously assumed 'sk' could be null (see line 1913) Thanks Dan, I've commited the following: -------------------- ipx: Remove spurious NULL checking in ipx_ioctl(). We already unconditionally dereference 'sk' via lock_sock(sk) earlier in this function, and our caller (sock_do_ioctl()) makes takes similar liberties. Reported-by: Dan Carpenter <dan.carpenter@...cle.com> Signed-off-by: David S. Miller <davem@...emloft.net> --- net/ipx/af_ipx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c index 824d4a3..dfd6faa 100644 --- a/net/ipx/af_ipx.c +++ b/net/ipx/af_ipx.c @@ -1901,9 +1901,7 @@ static int ipx_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) (const unsigned short __user *)argp); break; case SIOCGSTAMP: - rc = -EINVAL; - if (sk) - rc = sock_get_timestamp(sk, argp); + rc = sock_get_timestamp(sk, argp); break; case SIOCGIFDSTADDR: case SIOCSIFDSTADDR: -- 1.7.10.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists