lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120519.143645.301502060316712408.davem@davemloft.net> Date: Sat, 19 May 2012 14:36:45 -0400 (EDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: b15745@...escale.com, netdev@...r.kernel.org Subject: Re: [PATCH] net : fix for dst_gc_task not getting scheduled if __dst_free() is called consistently From: Eric Dumazet <eric.dumazet@...il.com> Date: Sat, 19 May 2012 12:04:23 +0200 > On Sat, 2012-05-19 at 04:44 -0500, b15745@...escale.com wrote: >> From: Rajan Gupta <b15745@...escale.com> >> >> dst_gc_work is cancelled and again rescheduled in __ds_free(). In case >> __dsf_free() is consistently called dst_gc_work will never get called resulting in >> memory not getting freed at all until one stops calling __dst_free >> Signed-off-by: Rajan Gupta <b15745@...escale.com> >> --- >> net/core/dst.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/core/dst.c b/net/core/dst.c >> index 8246d47..6820206 100644 >> --- a/net/core/dst.c >> +++ b/net/core/dst.c >> @@ -215,7 +215,6 @@ void __dst_free(struct dst_entry *dst) >> if (dst_garbage.timer_inc > DST_GC_INC) { >> dst_garbage.timer_inc = DST_GC_INC; >> dst_garbage.timer_expires = DST_GC_MIN; >> - cancel_delayed_work(&dst_gc_work); >> schedule_delayed_work(&dst_gc_work, dst_garbage.timer_expires); >> } >> spin_unlock_bh(&dst_garbage.lock); > > Strange, I never met this.... > > Since "if (dst_garbage.timer_inc > DST_GC_INC)" will be false if > timer_inc is DST_GC_INC. I'm not considering this patch at all until we figure out what the real situation is here. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists