netdev - Re: [PATCH V2] ipv4: fix the rcu race between free_fib_info and ip_route_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337827362.3361.3800.camel@edumazet-glaptop>
Date:	Thu, 24 May 2012 04:42:42 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"kun.jiang" <kunx.jiang@...el.com>
Cc:	netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	YMZHANG <yanmin_zhang@...ux.intel.com>, davem@...emloft.net
Subject: Re: [PATCH V2] ipv4: fix the rcu race between free_fib_info and
 ip_route_output_slow

On Thu, 2012-05-24 at 09:39 +0800, kun.jiang wrote:
> From: Yanmin Zhang <yanmin_zhang@...ux.intel.com>
> 
> We hit a kernel OOPS.
> 
...
> 
> Function free_fib_info resets nexthop_nh->nh_dev to NULL before releasing
> fi. Other cpu might be accessing fi. Fixing it by delaying the releasing.
> 
> With the patch, we ran MTBF testing on Android mobile for 12 hours
> and didn't trigger the issue.
> 
> Thank Eric for very detailed review/checking the issue.
> 
> Signed-off-by: Yanmin Zhang <yanmin_zhang@...ux.intel.com>
> Signed-off-by: Kun Jiang <kunx.jiang@...el.com>
> ---
>  net/ipv4/fib_semantics.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html