netdev - Re: [PATCH] tcp: take care of overlaps in tcp_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120524.002742.1295533350623902945.davem@davemloft.net>
Date:	Thu, 24 May 2012 00:27:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	lists@...e.net, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: take care of overlaps in tcp_try_coalesce()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 24 May 2012 05:51:37 +0200

> [PATCH] tcp: take care of overlaps in tcp_try_coalesce()
> 
> Sergio Correia reported following warning :
> 
> WARNING: at net/ipv4/tcp.c:1301 tcp_cleanup_rbuf+0x4f/0x110()
> 
> WARN(skb && !before(tp->copied_seq, TCP_SKB_CB(skb)->end_seq),
>      "cleanup rbuf bug: copied %X seq %X rcvnxt %X\n",
>      tp->copied_seq, TCP_SKB_CB(skb)->end_seq, tp->rcv_nxt);
> 
> It appears TCP coalescing, and more specifically commit b081f85c297
> (net: implement tcp coalescing in tcp_queue_rcv()) should take care of
> possible segment overlaps in receive queue. This was properly done in
> the case of out_or_order_queue by the caller.
> 
> For example, segment at tail of queue have sequence 1000-2000, and we
> add a segment with sequence 1500-2500.
> This can happen in case of retransmits.
> 
> In this case, just don't do the coalescing.
> 
> Reported-by: Sergio Correia <lists@...e.net>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Sergio Correia <lists@...e.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html