netdev - Re: [RFC] skb: avoid unnecessary reallocations in __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1338297967.2840.31.camel@edumazet-glaptop>
Date:	Tue, 29 May 2012 15:26:07 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Felix Fietkau <nbd@...nwrt.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] skb: avoid unnecessary reallocations in __skb_cow

On Tue, 2012-05-29 at 15:10 +0200, Felix Fietkau wrote:

> I don't have any real use case in mind, but it's not really adding an
> extra NET_SKB_PAD, it simply fills up the headroom to NET_SKB_PAD,

This is not what is doing your patch.

If cloned is true, and current skb headroom less than 64, you add an
extra 64 bytes of headroom.

Just keep it simple, this is inline code and should be kept as small as
possible.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html