lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 May 2012 17:28:43 -0400 (EDT) From: David Miller <davem@...emloft.net> To: florian@...nwrt.org Cc: devendra.aaru@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] r6040: disable pci device if the subsequent calls (after pci_enable_device) fails From: David Miller <davem@...emloft.net> Date: Tue, 29 May 2012 17:22:29 -0400 (EDT) > From: Florian Fainelli <florian@...nwrt.org> > Date: Tue, 29 May 2012 11:20:50 +0200 > >> On Monday 28 May 2012 17:27:03 Devendra Naga wrote: >>> the calls after the pci_enable_device may fail, and will error out with out >>> disabling it. disable the device at error paths. >> >> Looks good, thanks Devendra! >> >>> >>> Signed-off-by: Devendra Naga <devendra.aaru@...il.com> >> >> Acked-by: Florian Fainelli <florian@...nwrt.org> > > Applied. Actually, reverted, you didn't test this patch at all. You didn't even look at the warnings emitted by the compiler with your changes installed. You're passing a network device pointer into the PCI device disable routine, which takes a PCI device pointer. I can't express to you how extremely irritating it is when people submit patches like this. The bug in question is 1,000 times less harmful than your fix. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists