lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 May 2012 14:41:02 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Daniel Baluta <dbaluta@...acom.com> Cc: Alexandru Copot <alex.mihai.c@...il.com>, davem@...emloft.net, gerrit@....abdn.ac.uk, kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org, Lucian Grijincu <lucian.grijincu@...il.com> Subject: Re: [RFC PATCH 0/4] inet: add second hash table On Wed, 2012-05-30 at 15:32 +0300, Daniel Baluta wrote: > Hi Eric, > > Usually our tests use a huge number of virtual interfaces. > Using this patch we get a massive improvement when there are many sockets > bound to the same port, but different addresses for both bind() and > listen() system calls (both call inet_csk_get_port). > > We provided some data points in the fourth patch: > > For 16.000 interfaces each with a distinct IPv4 address, doing bind > and then listen we get: > > > If I understood it correctly, a similar patch was introduced > for UDP some time ago. [2] > > thanks, > Daniel. > > [1] http://ixlabs.cs.pub.ro/gitweb/?p=port-allocation.git;a=tree;f=testbind;h=687e4452101e13cb5995b43c1351d76786d98fdd;hb=HEAD > [2] http://www.spinics.net/lists/netdev/msg112056.html UDP case was a bit different, since production machine could really have thousand of UDP flows for tunnel terminations. But for TCP, unless your very specific needs I don't see the real need to review 400 lines of patches ? Nobody but you ever complained of listen() being performance critical with 16.000 IP on a machime... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists