netdev - Re: Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 May 2012 16:42:54 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Hiroaki SHIMODA <shimoda.hiroaki@...il.com>,
	Tom Herbert <therbert@...gle.com>,
	Denys Fedoryshchenko <denys@...p.net.lb>,
	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	davem@...emloft.net
Subject: Re: Strange latency spikes/TX network stalls on Sun Fire
 X4150(x86) and e1000e

On Wed, 2012-05-30 at 07:09 -0700, Joe Perches wrote:

> Whatever evals A and B once would be better.

Why do you believe they could be evaluated several time ?

#define POSDIFF(A, B) max_t(int, (A) - (B), 0)

(A) - (B) is done once, or its a huge max_t() bug.

By the way, we handle 32bit values here. No way BQL can overflow a 4GB
limit.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html