[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120601.142317.1843610571282799477.davem@davemloft.net>
Date: Fri, 01 Jun 2012 14:23:17 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: jasowang@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
mst@...hat.com
Subject: Re: [PATCH 2/2] 8139cp/8139too: terminate the eeprom access with
the right opmode
From: Jason Wang <jasowang@...hat.com>
Date: Fri, 01 Jun 2012 12:19:48 +0800
> Currently, we terminate the eeprom access through clearing the CS by:
>
> RTL_W8 (Cfg9346, ~EE_CS); or writeb (~EE_CS, ee_addr);
>
> This would left the eeprom into "Config. Register Write Enable:"
> state which is not expcted as the highest two bits were set to
> 0x11 ( expected is the "Normal" mode (0x00)). Solving this by write
> 0x0 instead of ~EE_CS when terminating the eeprom access.
>
> Signed-off-by: Jason Wang <jasowang@...hat.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists