netdev - Re: [PATCH 1/1] fec_mpc52xx: fix timestamp filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Jun 2012 21:06:05 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Stephan Gatzka <stephan@...zka.org>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH 1/1] fec_mpc52xx: fix timestamp filtering

On Sat, Jun 02, 2012 at 03:04:06PM +0200, Stephan Gatzka wrote:
> skb_defer_rx_timestamp was called with a freshly allocated skb but must
> be called with rskb instead.

Thanks for checking this, and sorry for the trouble it caused you.

Acked-by: Richard Cochran <richardcochran@...il.com>

> 
> Signed-off-by: Stephan Gatzka <stephan@...zka.org>
> Cc: stable <stable@...r.kernel.org>
> ---
>  drivers/net/ethernet/freescale/fec_mpc52xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/ethernet/freescale/fec_mpc52xx.c
> index 97f947b..2933d08 100644
> --- a/drivers/net/ethernet/freescale/fec_mpc52xx.c
> +++ b/drivers/net/ethernet/freescale/fec_mpc52xx.c
> @@ -437,7 +437,7 @@ static irqreturn_t mpc52xx_fec_rx_interrupt(int irq, void *dev_id)
>  		length = status & BCOM_FEC_RX_BD_LEN_MASK;
>  		skb_put(rskb, length - 4);	/* length without CRC32 */
>  		rskb->protocol = eth_type_trans(rskb, dev);
> -		if (!skb_defer_rx_timestamp(skb))
> +		if (!skb_defer_rx_timestamp(rskb))
>  			netif_rx(rskb);
>  
>  		spin_lock(&priv->lock);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html