netdev - Re: [PATCH net-next] tcp: tcp_make_synack() can use alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Jun 2012 11:33:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: tcp_make_synack() can use alloc_skb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 04 Jun 2012 07:50:43 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> There is no value using sock_wmalloc() in tcp_make_synack().
> 
> A listener socket only sends SYNACK packets, they are not queued in a
> socket queue, only in Qdisc and device layers, so the number of in
> flight packets is limited in these layers. We used sock_wmalloc() with
> the %force parameter set to 1 to ignore socket limits anyway.
> 
> This patch removes two atomic operations per SYNACK packet.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Looks good, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html