netdev - Re: [PATCH (net.git) 1/4] stmmac: remove two useless initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120604.114940.813410325113851773.davem@davemloft.net>
Date:	Mon, 04 Jun 2012 11:49:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH (net.git) 1/4] stmmac: remove two useless initialisation

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Mon,  4 Jun 2012 17:37:47 +0200

> This patch removes two useful initialisation in the
> stmmac_rx and stmmac_tx function.
> In the former, count var was already reset and in the
> stmmac_tx we only need to increment the dirty pointer
> w/o setting the entry var.
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

There are so many problems with this patch I do not know where
to start.

Your subject line says the initializations are "useless" yet
your commit message says they are "useful".

This is a cleanup, and does not fix any bugs, and is therefore
absolutely not appropriate for the 'net' tree.

I'm tossing this entire series, you need to be more careful
with your submissions.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html