netdev - Re: [PATCH net-next 5/5] gianfar_ethtool: coding style and whitespace cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120605.143814.549248889886122109.davem@davemloft.net>
Date:	Tue, 05 Jun 2012 14:38:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	jan.ceuleers@...puter.org, b06378@...escale.com, joe@...ches.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/5] gianfar_ethtool: coding style and
 whitespace cleanups

From: Florian Fainelli <florian@...nwrt.org>
Date: Tue, 05 Jun 2012 12:54:34 +0200

> Hi,
> 
> On Tuesday 05 June 2012 12:49:43 Jan Ceuleers wrote:
>> On 06/05/2012 11:14 AM, David Miller wrote:
>> > From: Jan Ceuleers <jan.ceuleers@...puter.org>
>> > Date: Tue, 05 Jun 2012 07:54:29 +0200
>> > 
>> >> So your build environment happens to be one of powerpc, alpha or mips,
>> >> does it?
>> > 
>> > No, I get those errors you posted too.
>> > 
>> > But like I said, you simply IGNORE THEM, and look for newly introduced
>> > errors and warnings.
>> 
>> David,
>> 
>> The error I quoted was a fatal error, meaning that compilation did not
>> proceed beyond the point to which the error pertained (inclusion of a
>> header that does not exist in my arch). So I cannot test-compile the
>> driver on my arch and draw any conclusions from that beyond line 91.
> 
> What about you setup a cross-compiler and build for one of these architectures 
> where the driver is enabled?

Dammit, people read what I'm saying.

This isn't even necessary for quick validation of patches.

You ignore the compile errors when you force build the driver, and
then you simply make sure you don't introduce any new errors of
warnings into the build.

For quick sanity checking a cross build is absolutely overkill and
simply not necessary.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html