lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 05 Jun 2012 07:16:56 +0200 From: Giuseppe CAVALLARO <peppe.cavallaro@...com> To: Ben Hutchings <bhutchings@...arflare.com> Cc: netdev@...r.kernel.org, Rayagond Kokatanur <rayagond@...avyalabs.com> Subject: Re: [PATCH (net.git) 3/3] stmmac: fix driver Kconfig when built as module On 6/4/2012 6:45 PM, Ben Hutchings wrote: > On Mon, 2012-06-04 at 18:32 +0200, Giuseppe CAVALLARO wrote: >> This patches fixes the driver when built as dyn module. >> In fact the platform part cannot be built and the probe fails >> (thanks to Bob Liu that reported this bug). >> >> v2: as D. Miller suggested, it is not necessary to make the >> pci and the platform code mutually exclusive. >> Having both could also help, at built time ,to verify that >> all the code is validated and compiles fine. >> >> Reported-by: Bob Liu <lliubbo@...il.com> >> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com> >> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com> > [...] > > What I said in <1337687765.11796.11.camel@...deye> was: > > That's because CONFIG_STMMAC_PLATFORM and CONFIG_STMMAC_PCI are wrongly > declared as tristate in Kconfig. Change them to bool and it should work > again. > > You can't add a 'Reviewed-by' line on the basis of this; you can only > add it if a reviewer writes that line themselves (and if you don't make > further changes). Thanks, I'm sending the patches again and sorry for the wrong usage of Reviewed-by. Peppe > > Ben. > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists