netdev - [PATCH v3 net-next 0/5] gianfar: coding style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue,  5 Jun 2012 15:42:10 +0200
From:	Jan Ceuleers <jan.ceuleers@...puter.org>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	Jiajun Wu <b06378@...escale.com>, Joe Perches <joe@...ches.com>,
	netdev@...r.kernel.org
Subject: [PATCH v3 net-next 0/5] gianfar: coding style cleanups

Various coding style cleanups, mostly whitespace and comment reformatting.

I have left a number of lines untouched where I felt that the changes I
was considering were not improving readability. But de gustibus etc.

Patch 4/5 also removes some superfluous local variable initialisations.
These are obviously correct because the variable is initialised again
right after. But you might consider this to be unnecessary code churn
because the compiler is unlikely to generate better code due to this patch.

WARNING: Compile-tested only. I do not have the hardware.

This is my first patch _series_ submission; please be kind.

v3: no changes from v2, except now compile-tested using powerpc crosstool

v2: fixed typo in 5/5 (found by David)

Jan Ceuleers (5):
  gianfar: whitespace cleanup - pointers and multiplications
  gianfar: comment cleanup
  gianfar: various coding style and whitespace cleanups
  gianfar: Remove superfluous initialisations
  gianfar_ethtool: coding style and whitespace cleanups

 drivers/net/ethernet/freescale/gianfar.c         |  491 +++++++++++-----------
 drivers/net/ethernet/freescale/gianfar_ethtool.c |  420 +++++++++---------
 2 files changed, 479 insertions(+), 432 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html