netdev - Re: [PATCH] snmp: fix OutOctets counter to include forwarded datagrams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120607.145326.1203419171187480651.davem@davemloft.net>
Date:	Thu, 07 Jun 2012 14:53:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bernat@...fy.cx
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] snmp: fix OutOctets counter to include forwarded
 datagrams

From: Vincent Bernat <bernat@...fy.cx>
Date: Tue,  5 Jun 2012 15:41:42 +0200

> RFC 4293 defines ipIfStatsOutOctets (similar definition for
> ipSystemStatsOutOctets):
> 
>    The total number of octets in IP datagrams delivered to the lower
>    layers for transmission.  Octets from datagrams counted in
>    ipIfStatsOutTransmits MUST be counted here.
> 
> And ipIfStatsOutTransmits:
> 
>    The total number of IP datagrams that this entity supplied to the
>    lower layers for transmission.  This includes datagrams generated
>    locally and those forwarded by this entity.
> 
> Therefore, IPSTATS_MIB_OUTOCTETS must be incremented when incrementing
> IPSTATS_MIB_OUTFORWDATAGRAMS.
> 
> IP_UPD_PO_STATS is not used since ipIfStatsOutRequests must not
> include forwarded datagrams:
> 
>    The total number of IP datagrams that local IP user-protocols
>    (including ICMP) supplied to IP in requests for transmission.  Note
>    that this counter does not include any datagrams counted in
>    ipIfStatsOutForwDatagrams.
> 
> Signed-off-by: Vincent Bernat <bernat@...fy.cx>

Applied, thanks for the detailed analysis.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html