lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1339270662.8170.6.camel@joe2Laptop> Date: Sat, 09 Jun 2012 12:37:42 -0700 From: Joe Perches <joe@...ches.com> To: Alexander Smirnov <alex.bluesman.smirnov@...il.com> Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH net-next v3 3/3] 6lowpan: remove excessive argument in pr_debug On Sat, 2012-06-09 at 19:13 +0400, Alexander Smirnov wrote: > Remove excessive __func__ argument in pr_debug function. Hello Alexander. trivial comments below: > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > @@ -240,7 +240,7 @@ lowpan_uncompress_addr(struct sk_buff *skb, struct in6_addr *ipaddr, > lowpan_uip_ds6_set_addr_iid(ipaddr, lladdr); > } > > - pr_debug("(%s): uncompressing %d + %d => ", __func__, prefcount, > + pr_debug("uncompressing %d + %d => ", prefcount, > postcount); It'd be nicer to move the second argument as well. pr_debug("uncompressing %d + %d => ", prefcount, postcount); [] > @@ -543,7 +541,7 @@ static int lowpan_header_create(struct sk_buff *skb, > hc06_ptr += 16; > } > } else { > - pr_debug("(%s): destination address is unicast: ", __func__); > + pr_debug("destination address is unicast: "); > /* TODO: context lookup */ > if (is_addr_link_local(&hdr->daddr)) { > pr_debug("destination address is link-local\n"); This doesn't really look correct. Should this be newline terminated? [] > @@ -894,14 +890,14 @@ lowpan_process_data(struct sk_buff *skb) > /* check for Multicast Compression */ > if (iphc1 & LOWPAN_IPHC_M) { > if (iphc1 & LOWPAN_IPHC_DAC) { > - pr_debug("(%s): destination address context-based " > - "multicast compression\n", __func__); > + pr_debug("destination address context-based " > + "multicast compression\n"); Please coalesce format strings. pr_debug("destination address context-based multicast compression\n"); [] > + pr_debug("destination address non-context-based" > + " multicast compression\n"); etc... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists