lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1339289854.21665.161.camel@deadeye.wl.decadent.org.uk> Date: Sun, 10 Jun 2012 01:57:34 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com> CC: <davem@...emloft.net>, Carolyn Wyborny <carolyn.wyborny@...el.com>, <netdev@...r.kernel.org>, <gospo@...hat.com>, <sassmann@...hat.com> Subject: Re: [net-next 3/9] igb: Update firmware info output On Sat, 2012-06-09 at 01:20 -0700, Jeff Kirsher wrote: > From: Carolyn Wyborny <carolyn.wyborny@...el.com> > > Our NVM image creation tools have evolved over the years and there are > multiple versions contained in them, depending on the tool used to create > them. This patch outputs the NVM versions available in ethtool -i output. [...] > --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c > +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c > @@ -718,20 +718,16 @@ static void igb_get_drvinfo(struct net_device *netdev, > struct ethtool_drvinfo *drvinfo) > { > struct igb_adapter *adapter = netdev_priv(netdev); > - u16 eeprom_data; > > strlcpy(drvinfo->driver, igb_driver_name, sizeof(drvinfo->driver)); > strlcpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version)); > > - /* EEPROM image version # is reported as firmware version # for > - * 82575 controllers */ > - adapter->hw.nvm.ops.read(&adapter->hw, 5, 1, &eeprom_data); > - snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), > - "%d.%d-%d", > - (eeprom_data & 0xF000) >> 12, > - (eeprom_data & 0x0FF0) >> 4, > - eeprom_data & 0x000F); > - > + /* > + * EEPROM image version # is reported as firmware version # for > + * 82575 controllers > + */ > + strlcpy(drvinfo->fw_version, adapter->fw_version, > + sizeof(drvinfo->fw_version)); [...] Doesn't this driver support online firmware upgrades using ETHTOOL_SEEPROM? If so then you should carry on reading the version from NVRAM here, rather than only doing it at probe time. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists