lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Jun 2012 19:52:50 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: Wolfgang Grandegger <wg@...ndegger.com>,
AnilKumar Ch <anilkumar@...com>,
"David S. Miller" <davem@...emloft.net>,
Jiri Kosina <jkosina@...e.cz>, linux-can@...r.kernel.org,
netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] can: c_can: precedence error in c_can_chip_config()
On 06/09/2012 05:56 PM, Dan Carpenter wrote:
> (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
> is zero so the condition is never true. The intent here was to test
> that both flags were set.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> This is a static checker fix. I'm not super familiar with the c_can
> code.
Good catch. Applied to can-next.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Download attachment "signature.asc" of type "application/pgp-signature" (263 bytes)
Powered by blists - more mailing lists