netdev - Re: [PATCH] dummy: fix rcu_sched self-detected stalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120610.224800.602807319671005890.davem@davemloft.net>
Date:	Sun, 10 Jun 2012 22:48:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] dummy: fix rcu_sched self-detected stalls

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 09 Jun 2012 12:59:06 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Trying to "modprobe dummy numdummies=30000" triggers :
> 
> INFO: rcu_sched self-detected stall on CPU { 8} (t=60000 jiffies)
> 
> After this splat, RTNL is locked and reboot is needed.
> 
> We must call cond_resched() to avoid this, even holding RTNL.
> 
> Also remove the ~32767 limit on number of dummies (PAGE_SIZE*8)
> 
> Tested with "modprobe dummy numdummies=128000"
> (it took ~12 minutes, because of sysfs)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

I'm all for the cond_resched() change, but the name optimization
belongs generically in net/core/dev.c not in specific drivers.

So, please submit this cond_resched() fix first then we can work
on the naming performance issue.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html