netdev - Re: [PATCH] net: Reorder initialization in ip_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120610.234411.850948486629299757.davem@davemloft.net>
Date:	Sun, 10 Jun 2012 23:44:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roland@...nel.org
Cc:	netdev@...r.kernel.org, roland@...estorage.com
Subject: Re: [PATCH] net: Reorder initialization in ip_route_output to fix
 gcc warning

From: Roland Dreier <roland@...nel.org>
Date: Sun, 10 Jun 2012 23:05:24 -0700

> From: Roland Dreier <roland@...estorage.com>
> 
> If I build with W=1, for every file that includes <net/route.h>, I get the warning
> 
>     include/net/route.h: In function 'ip_route_output':
>     include/net/route.h:135:3: warning: initialized field overwritten [-Woverride-init]
>     include/net/route.h:135:3: warning: (near initialization for 'fl4') [-Woverride-init]
> 
> (This is with "gcc (Debian 4.6.3-1) 4.6.3")
> 
> A fix seems pretty trivial: move the initialization of .flowi4_tos
> earlier.  As far as I can tell, this has no effect on code generation.
> 
> Signed-off-by: Roland Dreier <roland@...estorage.com>

I can't figure out what it is actually warning about, can you?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html