lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120611.183454.1290469931190793239.davem@davemloft.net> Date: Mon, 11 Jun 2012 18:34:54 -0700 (PDT) From: David Miller <davem@...emloft.net> To: pablo@...filter.org Cc: wfg@...ux.intel.com, gaofeng@...fujitsu.com, netdev@...r.kernel.org Subject: Re: net/netfilter/nf_conntrack_proto_tcp.c:1606:9: error: ‘struct nf_proto_net’ has no member named ‘user’ From: Pablo Neira Ayuso <pablo@...filter.org> Date: Tue, 12 Jun 2012 02:26:55 +0200 > Would you be OK if I send you patches to move all sysctl part of > nf_conntrack_proto_*.c to nf_conntrack_proto_*_sysctl.c > > I can also do the same for nf_conntrack_proto.c. > > This means more files under the net/netfilter directory, but less > ifdef kludges in the code. > > Please, have a look at the patch enclosed to this email in case you > want to see how it would look like in the end with my proposal. Looks good to me. But I have to ask, why are you able to now unconditionally use pn->users vs. pn->ctl_table in those tests? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists