netdev - Re: [PATCH 0/8] dcbnl: Major simplifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120613.155541.26513304496438357.davem@davemloft.net>
Date:	Wed, 13 Jun 2012 15:55:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org, lucy.liu@...el.com,
	john.r.fastabend@...el.com, alexander.h.duyck@...el.com
Subject: Re: [PATCH 0/8] dcbnl: Major simplifications

From: Thomas Graf <tgraf@...g.ch>
Date: Wed, 13 Jun 2012 14:54:53 +0200

> The dcbnl code is overly complicated when constructing the reply
> message. This series of patches simplifies the process and
> introduces consistent error codes allowing user space to figure
> out what went wrong.
> 
> Patches have been tested with ixgbe in a FCoE setup.
> 
> Thomas Graf (8):
>   dcbnl: Prepare framework to shorten handling functions
>   dcbnl: Shorten all command handling functions
>   dcbnl: Remove now unused dcbnl_reply()
>   dcbnl: Use dcbnl_newmsg() where possible
>   dcbnl: Return consistent error codes
>   dcbnl: Move dcb app lookup code into dcb_app_lookup()
>   dcbnl: Move dcb app allocation into dcb_app_add()
>   dcbnl: Use type safe nlmsg_data()

Lots of deleted code, I like it :-)

Applied, but could you send a follow-on patch to use BUG_ON() instead
of that "if (!ptr) { /* ... */ BUG(); }" construct?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html