netdev - Re: [PATCH net-next] bonding: remove packet cloning in recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120612.185210.950874013557330917.davem@davemloft.net>
Date:	Tue, 12 Jun 2012 18:52:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, andy@...yhouse.net,
	jbohac@...e.cz, nicolas.2p.debian@...e.fr, maze@...gle.com
Subject: Re: [PATCH net-next] bonding: remove packet cloning in recv_probe()

From: Jay Vosburgh <fubar@...ibm.com>
Date: Tue, 12 Jun 2012 17:47:59 -0700

> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
>>From: Eric Dumazet <edumazet@...gle.com>
>>
>>Cloning all packets in input path have a significant cost.
>>
>>Use skb_header_pointer()/skb_copy_bits() instead of pskb_may_pull() so
>>that recv_probe handlers (bond_3ad_lacpdu_recv / bond_arp_rcv /
>>rlb_arp_recv ) dont touch input skb.
>>
>>bond_handle_frame() can avoid the skb_clone()/dev_kfree_skb()
>>
>>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>Cc: Jay Vosburgh <fubar@...ibm.com>
>>Cc: Andy Gospodarek <andy@...yhouse.net>
>>Cc: Jiri Bohac <jbohac@...e.cz>
>>Cc: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
>>Cc: Maciej Żenczykowski <maze@...gle.com>
> 
> 	This looks really good to me.
> 
> 	-J
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html