netdev - Re: [RFC] net/sched/em_canid: Ematch rule to match CAN frames according to their CAN IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120613121828.GP28598@canuck.infradead.org>
Date:	Wed, 13 Jun 2012 08:18:28 -0400
From:	Thomas Graf <tgraf@...g.ch>
To:	Michal Sojka <sojkam1@....cvut.cz>
Cc:	Oliver Hartkopp <socketcan@...tkopp.net>,
	Rostislav Lisovy <lisovy@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
	linux-can@...r.kernel.org, lartc@...r.kernel.org,
	pisa@....felk.cvut.cz
Subject: Re: [RFC] net/sched/em_canid: Ematch rule to match CAN frames
 according to their CAN IDs

On Wed, Jun 13, 2012 at 11:52:10AM +0200, Michal Sojka wrote:
> The performance of ematch might be slightly lower than of standalone
> classifier. Rosta will compare the performance soon. 

I think it doesn't make a difference, there is no additional locking
involved. Numbers definitely welcome though.

> > E.g. is it still possible to add additional ematches like checking for
> > patterns inside can_frame.data[] (which is located in skb->data) with
> > ematch_u32 or e.g. ematch_text ??
> 
> AFAIK, this should be possible and it will be a big advantage over
> implementation as a standalone classifier.

Definitely and the real advantage is that you can combine these
using logic operators.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html