netdev - Re: [PATCH 3/3] be2net: Increase statistics structure size for skyhawk.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339699802.2719.26.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 14 Jun 2012 19:50:02 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<sarveshwar.bandi@...lex.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	Vasundhara Volam <vasundhara.volam@...lex.com>
Subject: Re: [PATCH 3/3] be2net: Increase statistics structure size for
 skyhawk.

On Thu, 2012-06-14 at 11:21 +0530, sarveshwar.bandi@...lex.com wrote:
> From: Vasundhara Volam <vasundhara.volam@...lex.com>
> 
> Increasing the hardware statistics structure to accomodate statistics for skyhawk.
> 
> Signed-off-by: Vasundhara Volam <vasundhara.volam@...lex.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_cmds.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
> index 2f6bb06..3c938f5 100644
> --- a/drivers/net/ethernet/emulex/benet/be_cmds.h
> +++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
> @@ -1566,7 +1566,7 @@ struct be_hw_stats_v1 {
>  	u32 rsvd0[BE_TXP_SW_SZ];
>  	struct be_erx_stats_v1 erx;
>  	struct be_pmem_stats pmem;
> -	u32 rsvd1[3];
> +	u32 rsvd1[18];
>  };
>  
>  struct be_cmd_req_get_stats_v1 {

Doesn't this merit a 'struct be_hw_stats_v2'?

Does this mean that the driver wasn't currently allocating enough memory
for the structure, and could that result in a buffer overrun?  If so
then this fix would need to go into 3.5 and 3.4.y as well.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html