netdev - Re: [PATCH] can: c_can: precedence error in c_can_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120615.152623.509401630460869805.davem@davemloft.net>
Date:	Fri, 15 Jun 2012 15:26:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mkl@...gutronix.de
Cc:	netdev@...r.kernel.org, linux-can@...r.kernel.org,
	dan.carpenter@...cle.com
Subject: Re: [PATCH] can: c_can: precedence error in c_can_chip_config()

From: Marc Kleine-Budde <mkl@...gutronix.de>
Date: Fri, 15 Jun 2012 12:20:44 +0200

> From: Dan Carpenter <dan.carpenter@...cle.com>
> 
> (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
> is zero so the condition is never true.  The intent here was to test
> that both flags were set.
> 
> Cc: <stable@...nel.org> # 2.6.39+
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html