netdev - Re: [PATCH] bnx2x: fix panic when TX ring is full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120615.153049.103988387813257203.davem@davemloft.net>
Date:	Fri, 15 Jun 2012 15:30:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com, evansr@...gle.com,
	eilong@...adcom.com, meravs@...adcom.com, yanivr@...adcom.com,
	willemb@...gle.com, thruby@...gle.com
Subject: Re: [PATCH] bnx2x: fix panic when TX ring is full

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 13 Jun 2012 21:45:16 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> There is a off by one error in the minimal number of BD in
> bnx2x_start_xmit() and bnx2x_tx_int() before stopping/resuming tx queue.
> 
> A full size GSO packet, with data included in skb->head really needs
> (MAX_SKB_FRAGS + 4) BDs, because of bnx2x_tx_split()
> 
> This error triggers if BQL is disabled and heavy TCP transmit traffic
> occurs.
> 
> bnx2x_tx_split() definitely can be called, remove a wrong comment.
> 
> Reported-by: Tomas Hruby <thruby@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

I got tired of waiting for the Broadcom "maintainers" to review this,
so I just applied it to 'net', thanks Eric.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html