netdev - Re: [PATCH] ipv6: Handle PMTU in ICMP error handlers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120615.200216.1185728435617216812.davem@davemloft.net>
Date:	Fri, 15 Jun 2012 20:02:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Handle PMTU in ICMP error handlers.

From: Neal Cardwell <ncardwell@...gle.com>
Date: Fri, 15 Jun 2012 22:42:25 -0400

> On Fri, Jun 15, 2012 at 6:00 PM, David Miller <davem@...emloft.net> wrote:
>> +++ b/include/net/ip6_route.h
>> +extern void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu,
>> +                           int oif, u32 mark);
> ...
>> +++ b/net/ipv6/route.c
>> +void ip6_update_pmtu(struct sk_buff *skb, struct net *net, u32 mtu,
>> +                    int oif, __be32 mark)
> 
> The .h and .c files disagree on the types of mtu and mark for
> ip6_update_pmtu(). Looks like the mtu should be __be32 in both. I'm
> guessing mark should also be __be32 in both, though I'm not yet
> familiar with that area of the code.
> 
> Otherwise looks great to me.

Thanks Neal, I've fixed it up as follows:

--------------------
[PATCH] ipv6: Fix types of ip6_update_pmtu().

The mtu should be a __be32, not the mark.

Reported-by: Neal Cardwell <ncardwell@...gle.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 net/ipv6/route.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c7ccc36..1c279fe 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1065,8 +1065,8 @@ static void ip6_rt_update_pmtu(struct dst_entry *dst, u32 mtu)
 	}
 }
 
-void ip6_update_pmtu(struct sk_buff *skb, struct net *net, u32 mtu,
-		     int oif, __be32 mark)
+void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu,
+		     int oif, u32 mark)
 {
 	const struct ipv6hdr *iph = (struct ipv6hdr *) skb->data;
 	struct dst_entry *dst;
-- 
1.7.10.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html