netdev - Re: mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201206171818.05299.jackm@dev.mellanox.co.il>
Date:	Sun, 17 Jun 2012 18:18:05 +0300
From:	Jack Morgenstein <jackm@....mellanox.co.il>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>, netdev@...r.kernel.org,
	dotanb@...lanox.co.il, Or Gerlitz <ogerlitz@...lanox.com>,
	yevgenyp@...lanox.co.il
Subject: Re: mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

On Sunday 10 June 2012 04:03, Ben Hutchings wrote:
> It would be more idiomatic to write the condition as:
> 
>         if (hca_param.global_caps & ~(u64)HCA_GLOBAL_CAP_MASK)
> 
> (although that cast probably belongs in the definition of
> HCA_GLOBAL_CAP_MASK).
> 
You are correct!
We need to submit a patch to fix this.

-Jack
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html