netdev - Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+v9cxZG6b1O7kOQpeTELtv0vHzqy-8NH84boMpim0BM+tp1eQ@mail.gmail.com>
Date:	Tue, 19 Jun 2012 00:25:15 +0800
From:	Huajun Li <huajun.li.lee@...il.com>
To:	Oliver Neukum <oneukum@...e.de>
Cc:	David Miller <davem@...emloft.net>, tom.leiming@...il.com,
	stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB

On Mon, Jun 18, 2012 at 3:23 PM, Oliver Neukum <oneukum@...e.de> wrote:
> Am Montag, 18. Juni 2012, 01:30:17 schrieb David Miller:
>> From: Huajun Li <huajun.li.lee@...il.com>
>> Date: Wed, 13 Jun 2012 20:50:31 +0800
>>
>> > intr_complete() submits URB even the interrupt endpoint stalls.
>> > This patch will try to activate the endpoint once the exception
>> > occurs, and then re-submit the URB if the endpoint works again.
>> >
>> > Signed-off-by: Huajun Li <huajun.li.lee@...il.com>
>>
>> Review from USB experts would be appreciated.
>
> The code implements a minimum error handler correctly.
> Did you observe a stall in actual hardware or is this a just
> in case patch?
>

This one is just a patch, thanks for your comments.

>        Regards
>                Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html