lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120618115558.1ef26a48@nehalam.linuxnetplumber.net> Date: Mon, 18 Jun 2012 11:55:58 -0700 From: Stephen Hemminger <shemminger@...tta.com> To: Bruce Allan <bruce.w.allan@...el.com>, Carolyn Wyborny <carolyn.wyborny@...el.com>, Don Skidmore <donald.c.skidmore@...el.com>, Greg Rose <gregory.v.rose@...el.com>, Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>, Alex Duyck <alexander.h.duyck@...el.com> Cc: "David S. Miller" <davem@...emloft.net>, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org Subject: [PATCH 2/2 net-next] ixgbe: remove xmit length check The check here is bogus. Since len is unsigned, it can never be negative. And it would be a bug in network stack to ever send a zero length packet to device. Signed-off-by: Stephen Hemminger <shemminger@...tta.com> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 2012-06-18 10:53:13.742310994 -0700 +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 2012-06-18 10:53:15.962279249 -0700 @@ -6380,11 +6380,6 @@ static netdev_tx_t ixgbe_xmit_frame(stru struct ixgbe_adapter *adapter = netdev_priv(netdev); struct ixgbe_ring *tx_ring; - if (skb->len <= 0) { - dev_kfree_skb_any(skb); - return NETDEV_TX_OK; - } - /* * The minimum packet size for olinfo paylen is 17 so pad the skb * in order to meet this minimum size requirement. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists