lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAH5GJ0p_9x_6sSN=UQW0Wh57LKGKwXnAiO+8UoB=Ex88gNWQsg@mail.gmail.com> Date: Mon, 18 Jun 2012 23:23:35 +0200 From: Federico Vaga <federico.vaga@...il.com> To: Marc Kleine-Budde <mkl@...gutronix.de> Cc: Wolfgang Grandegger <wg@...ndegger.com>, Giancarlo Asnaghi <giancarlo.asnaghi@...com>, Alan Cox <alan@...ux.intel.com>, linux-can@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Bhupesh SHARMA <bhupesh.sharma@...com>, AnilKumar Chimata <anilkumar@...com>, Alessandro Rubini <rubini@...dd.com> Subject: Re: [PATCH] c_can_pci: generic module for C_CAN/D_CAN on PCI > I get this warning: > > socketcan/linux/drivers/net/can/c_can/c_can_pci.c: In function 'c_can_pci_probe': > socketcan/linux/drivers/net/can/c_can/c_can_pci.c:71: warning: 'priv' may be used uninitialized in this function > > What about: > > - pci_iounmap(pdev, priv->base); > + pci_iounmap(pdev, addr); I didn't get this warning, but I read again the code and the warning is correct, so pci_iounmap(pdev, addr) is the right way. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists