lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jun 2012 19:07:58 +0300 From: "Eilon Greenstein" <eilong@...adcom.com> To: "Alexander Duyck" <alexander.h.duyck@...el.com> cc: "Yuval Mintz" <yuvalmin@...adcom.com>, netdev@...r.kernel.org, davem@...emloft.net, "Jeff Kirsher" <jeffrey.t.kirsher@...el.com>, "Wyborny, Carolyn" <carolyn.wyborny@...el.com> Subject: Re: [RFC net-next 06/14] Fix intel/igb On Tue, 2012-06-19 at 08:42 -0700, Alexander Duyck wrote: > On 06/19/2012 08:14 AM, Yuval Mintz wrote: > > Signed-off-by: Yuval Mintz <yuvalmin@...adcom.com> > > Signed-off-by: Eilon Greenstein <eilong@...adcom.com> > > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > > --- > > drivers/net/ethernet/intel/igb/igb_main.c | 14 ++++++++------ > > 1 files changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > > index dd3bfe8..8e7ade5 100644 > > --- a/drivers/net/ethernet/intel/igb/igb_main.c > > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > > @@ -2380,18 +2380,20 @@ static int __devinit igb_sw_init(struct igb_adapter *adapter) > > #endif /* CONFIG_PCI_IOV */ > > switch (hw->mac.type) { > > case e1000_i210: > > - adapter->rss_queues = min_t(u32, IGB_MAX_RX_QUEUES_I210, > > - num_online_cpus()); > > + adapter->rss_queues = IGB_MAX_RX_QUEUES_I210; > > break; > > case e1000_i211: > > - adapter->rss_queues = min_t(u32, IGB_MAX_RX_QUEUES_I211, > > - num_online_cpus()); > > + adapter->rss_queues = IGB_MAX_RX_QUEUES_I211; > > break; > > default: > > - adapter->rss_queues = min_t(u32, IGB_MAX_RX_QUEUES, > > - num_online_cpus()); > > + adapter->rss_queues = IGB_MAX_RX_QUEUES; > > break; > > } > > + > > + adapter->rss_queues = min_t(u32, adapter->rss_queues, > > + min_t(u32, num_online_cpus(), > > + DEFAULT_MAX_NUM_RSS_QUEUES)); > > + > > /* i350 cannot do RSS and SR-IOV at the same time */ > > if (hw->mac.type == e1000_i350 && adapter->vfs_allocated_count) > > adapter->rss_queues = 1; > Same issue here as ixgbevf, only we support a max of 8 Rx queues in the > hardware. So now you are once again adding another unnecessary limit on > something that is already limited to 8 or less. > Same issue and same reply :) It is here to support a change of the DEFAULT_MAX_NUM_RSS_QUEUES macro. Eilon -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists