[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20120619.003157.1182913417516661199.davem@davemloft.net>
Date: Tue, 19 Jun 2012 00:31:57 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jason77.wang@...il.com
Cc: david.choi@...rel.com, nobuhiro.iwamatsu.yj@...esas.com,
netdev@...r.kernel.org
Subject: Re: [PATCH] phy/micrel: change phy_id_mask for KSZ9021 and KS8001
From: Hui Wang <jason77.wang@...il.com>
Date: Mon, 18 Jun 2012 16:52:09 +0800
> On a freescale imx6q platform, a hardware phy chip KSZ9021 is
> recognized as a KS8001 chip by the current driver like this:
> eth0: Freescale FEC PHY driver [Micrel KS8001 or KS8721]
>
> KSZ9021 has phy_id 0x00221610, while KSZ8001 has phy_id
> 0x0022161a, the current phy_id_mask (0x00fffff0/0x00ffff10) can't
> distinguish them. So change phy_id_mask to resolve this problem.
>
> Although the micrel datasheet says that the 4 LSB of phyid2 register
> contains the chip revision number and the current driver is designed
> to follow this rule, in reality the chip implementation doesn't follow
> it.
>
> Cc: David J. Choi <david.choi@...rel.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
> Signed-off-by: Hui Wang <jason77.wang@...il.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists