| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACVXFVML6Qd-Js9ekJhsXA9YW=LTXdcmC-874gzHE=4yTnVzdA@mail.gmail.com> Date: Tue, 19 Jun 2012 23:50:14 +0800 From: Ming Lei <tom.leiming@...il.com> To: Oliver Neukum <oneukum@...e.de> Cc: Huajun Li <huajun.li.lee@...il.com>, David Miller <davem@...emloft.net>, stern@...land.harvard.edu, linux-usb@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB On Tue, Jun 19, 2012 at 12:51 AM, Oliver Neukum <oneukum@...e.de> wrote: > > Then I am inclined to say that this is not fully thought through > If the endpoint stalls, the device has detected an error. > We have no idea how to generically handle this error. > We might come into a vicious circle. Why does it come into a vicious circle? If the interrupt endpoint is HALTed, the clear halt event is scheduled to call usb_clear_halt(int pipe), and if it returns successfully, the pipe shouldn't be halted any more, so the later usb_submit_urb() should be OK on the interrupt endpoint. The similar handling policy is taken for RX/TX endpoints in case they are halted. > Could you add a sanity limit for the > amount of halts we clear? Looks it is not needed, at least clearing HALT on Rx/Tx endpoints works well without the limit. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists