netdev - RE: linux-next: build failure after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5ECB3C7A6F99444980976A8C6D896384FAA275CBE@EAPEX1MAIL1.st.com>
Date:	Wed, 20 Jun 2012 12:45:46 +0800
From:	Bhupesh SHARMA <bhupesh.sharma@...com>
To:	David Miller <davem@...emloft.net>
Cc:	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"federico.vaga@...il.com" <federico.vaga@...il.com>,
	Giancarlo ASNAGHI <giancarlo.asnaghi@...com>,
	"wg@...ndegger.com" <wg@...ndegger.com>,
	"mkl@...gutronix.de" <mkl@...gutronix.de>
Subject: RE: linux-next: build failure after merge of the net-next tree

Hi David,

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Wednesday, June 20, 2012 10:07 AM
> To: Bhupesh SHARMA
> Cc: sfr@...b.auug.org.au; netdev@...r.kernel.org; linux-
> next@...r.kernel.org; linux-kernel@...r.kernel.org;
> federico.vaga@...il.com; Giancarlo ASNAGHI; wg@...ndegger.com;
> mkl@...gutronix.de
> Subject: Re: linux-next: build failure after merge of the net-next tree
> 
> From: Bhupesh SHARMA <bhupesh.sharma@...com>
> Date: Wed, 20 Jun 2012 12:27:11 +0800
> 
> > clk_get/clk_put* variants are usually used by ARM platforms.
> > Protecting their calls under macro 'CONFIG_HAVE_CLK' should solve the
> problem.
> 
> No, we don't pepper foo.c files with crappy ifdefs.

So, whether adding a check in Kconfig for HAVE_CLK be a proper solution ?
But that will limit the compilation of this driver for only platforms which are ARM based.

One may need to support this driver on x86 like platforms also..

Regards,
Bhupesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html