netdev - Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jun 2012 10:58:55 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Huajun Li <huajun.li.lee@...il.com>,
	David Miller <davem@...emloft.net>, stern@...land.harvard.edu,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB

Am Mittwoch, 20. Juni 2012, 10:07:55 schrieb Ming Lei:
> On Wed, Jun 20, 2012 at 4:00 PM, Oliver Neukum <oneukum@...e.de> wrote:
> >
> > Very well, on second thought, this patch makes sense.
> > Could you resend and I'll ack?
> 
> BTW, maybe it is better to add below
> 
>     usbnet_defer_kevent(dev, EVENT_STS_HALT);
> 
> for -EPIPE returned from usb_urb_submit if it will be resent.

Why? If it failed once it'll probably also fail the next time.
In that case we'd need to do something more intrusive
like resetting the device, but that cannot be done well
in the generic usbnet part.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html