netdev - RE: [PATCH net-next (v2) 2/6] bnx2x: link cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <979A8436335E3744ADCD3A9F2A2B68A502A441@SJEXCHMB10.corp.ad.broadcom.com>
Date:	Thu, 21 Jun 2012 17:52:16 +0000
From:	"Yuval Mintz" <yuvalmin@...adcom.com>
To:	"Joe Perches" <joe@...ches.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"Yaniv Rosner" <yaniv.rosner@...adcom.com>
Subject: RE: [PATCH net-next (v2) 2/6] bnx2x: link cleanup

> > This patch does several things:
> []
> >  3. Change msleep(small) --> usleep_range(small, small*2).
> >     Also correct existing calls to usleep_range.
> 
> Just fyi:
> 
> There are some more of these duplicated arg
> usleep_range uses in other files too
> 
> cheers, Joe

Hi Joe,

Yes - after you've awakened my awareness of the issue I've
taken a look at our driver and found the other occurrences as well.

However, since this patch series was meant to add some functionality
to our link code and its cleanup is a byproduct, I didn't want to add a 
new (unrelated) patch to the series.

Hopefully, next patch series we'll send will remedy all of these 
occurrences in our driver.

Thanks,
Yuval