netdev - Re: [PATCH] Allow receiving packets on the fallback tunnel if they pass sanity checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120620.210405.2231549940491911080.davem@davemloft.net>
Date:	Wed, 20 Jun 2012 21:04:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	phil@...m.com
Cc:	netdev@...r.kernel.org, phild@...com
Subject: Re: [PATCH] Allow receiving packets on the fallback tunnel if they
 pass sanity checks

From: Phil Dibowitz <phil@...m.com>
Date: Tue, 5 Jun 2012 08:40:58 -0700

> From b413062771afbba064ae9bc49b5daed7abb1243d Mon Sep 17 00:00:00 2001
> From: Ville Nuorvala <ville.nuorvala@...il.com>
> Subject: [PATCH] Allow receiving packets on the fallback tunnel if they pass sanity checks
> 
> The same IPv6 address checks are performed as with any normal tunnel,
> but as the fallback tunnel endpoint addresses are unspecified, the checks
> must be performed on a per-packet basis, rather than at tunnel
> configuration time.
> 
> Signed-off-by: Ville Nuorvala <ville.nuorvala@...il.com>
> Tested-by: Phil Dibowitz <phil@...m.com>

I've reviewed this change but I still have no idea why it's
necessary.

You need to compose a more lengthy and detailed commit log message
explaining everything before I'm going to consider applying this
patch.

You can't just say "we have some problem at Facebook, this patch fixes
it", and then merely describe word by word the content of the patch
without explaining the "why".  That simply doesn't cut it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html