netdev - Re: [PATCH] net: Update netdev_alloc_frag to work more efficiently with TCP and GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340255226.4604.3774.camel@edumazet-glaptop>
Date:	Thu, 21 Jun 2012 07:07:06 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexander Duyck <alexander.duyck@...il.com>
Cc:	Alexander Duyck <alexander.h.duyck@...el.com>,
	netdev@...r.kernel.org, davem@...emloft.net,
	jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH] net: Update netdev_alloc_frag to work more efficiently
 with TCP and GRO

On Wed, 2012-06-20 at 21:07 -0700, Alexander Duyck wrote:
> On 6/20/2012 6:21 AM, Eric Dumazet wrote:

> > +		nc->page = alloc_pages(GFP_ATOMIC | __GFP_COLD |
> > +				       (NETDEV_FRAG_ORDER ? __GFP_COMP : 0),
> > +				       NETDEV_FRAG_ORDER);

> I was wondering if you needed the check for NETDEV_FRAG_ORDER here.  
>  From what I can tell setting __GFP_COMP for an order 0 page has no 
> effect since it only seems to get checked in prep_new_page and that is 
> after a check to verify if the page is order 0 or not.

Good point, it seems some net drivers could be changed to remove
useless tests.

I'll post some performance data as well.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html