lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Jun 2012 18:27:17 +0200 From: Bjørn Mork <bjorn@...k.no> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: netdev@...r.kernel.org Subject: Re: net: qmi_wwan: bind to both control and data interface Dan Carpenter <dan.carpenter@...cle.com> writes: > The patch 230718bda1be: "net: qmi_wwan: bind to both control and data > interface" from Jun 19, 2012, leads to the following Smatch warning: > drivers/net/usb/qmi_wwan.c:206 qmi_wwan_bind() > error: potential NULL dereference 'cdc_union'. > > drivers/net/usb/qmi_wwan.c > 205 /* verify CDC Union */ > 206 if (desc->bInterfaceNumber != cdc_union->bMasterInterface0) { > ^^^^^^^^^ > > cdc_union is only non-NULL for USB_CDC_UNION_TYPE. We used to check for > NULL here but your patch removes the check. I just want to verify that > that was intended. > > 207 dev_err(&intf->dev, "bogus CDC Union: master=%u\n", cdc_union->bMasterInterface0); > 208 goto err; > 209 } > 210 Thanks for the notification, but this was intentional while touching the code anyway. The test always was redundant because the parsing code ensure that cdc_union cannot be NULL at that point. Bjørn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists