netdev - Re: [RFC net-next (v2) 14/14] ixgbevf: set maximal number of default RSS queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FE88794.9090704@intel.com>
Date:	Mon, 25 Jun 2012 08:45:24 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	Yuval Mintz <yuvalmin@...adcom.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, eilong@...adcom.com,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Greg Rose <gregory.v.rose@...el.com>
Subject: Re: [RFC net-next (v2) 14/14] ixgbevf: set maximal number of default
 RSS queues

On 06/25/2012 04:45 AM, Yuval Mintz wrote:
> Signed-off-by: Yuval Mintz <yuvalmin@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: Alexander Duyck <alexander.h.duyck@...el.com>
> Cc: Greg Rose <gregory.v.rose@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index f69ec42..7889644 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -2023,7 +2023,7 @@ static int ixgbevf_set_interrupt_capability(struct ixgbevf_adapter *adapter)
>  	 * (roughly) twice the number of vectors as there are CPU's.
>  	 */
>  	v_budget = min(adapter->num_rx_queues + adapter->num_tx_queues,
> -		       (int)(num_online_cpus() * 2)) + NON_Q_VECTORS;
> +		       netif_get_num_default_rss_queues() * 2) + NON_Q_VECTORS;
>  
>  	/* A failure in MSI-X entry allocation isn't fatal, but it does
>  	 * mean we disable MSI-X capabilities of the adapter. */
I'm not even sure why you are bothering to alter this driver since it is
currently single queue only.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html